Ignore unknown test app messages #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nmattia
force-pushed
the
nm-ignore-unknown-resps
branch
2 times, most recently
from
56ae897 to
641d556
Compare
This updates the test app to ignore unknown window events. Some extensions, like metamask, send seemingly arbitrary messages to the window which confuses the test app. With these changes we try to figure out if a message was intended for us by 1. Ensuring a request was started 2. Checking the jsonrpc response ID
nmattia
force-pushed
the
nm-ignore-unknown-resps
branch
from
641d556 to
f3dd093
Compare
frederikrothenberger
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test app to ignore unknown window events. Some extensions, like metamask, send seemingly arbitrary messages to the window which confuses the test app.
With these changes we try to figure out if a message was intended for us by
🟡 Some screens were changed